Add accumulation for all backends using AcceleratedKernels.jl #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiangnrd
force-pushed
the
accumulatetests
branch
from
38a0a8b to
c37267a
Compare
christiangnrd
changed the title
christiangnrd
force-pushed
the
accumulatetests
branch
4 times, most recently
from
3203ff8 to
c9c6256
Compare
Can you elaborate? AFAIU, AK only depends on GPUArraysCore, so GPUArrays should be able to depend on AK, no? |
christiangnrd
force-pushed
the
accumulatetests
branch
from
5fa011f to
1bb1d3f
Compare
This reverts commit 01e9209.
Not really... I was getting an error only on 1.10 but it went away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal implementation for
accumulate